Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Naming of Metrics #2312

Merged
merged 5 commits into from
Mar 1, 2021
Merged

Switch Naming of Metrics #2312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
501cc31
Switch Naming of Metrics
ejwessel Feb 27, 2021
ed7c90d
REVERTTHIS
estebanmino Mar 1, 2021
6c130fc
Revert "REVERTTHIS"
ejwessel Mar 1, 2021
c8ddd46
rmcomment
estebanmino Mar 1, 2021
87963eb
SWAP_TRACKING_FAILED
estebanmino Mar 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/core/Analytics.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@ class Analytics {
this.enabled = enabled;
this.listeners = [];
Analytics.instance = this;
// if (!__DEV__) {
RCTAnalytics.optIn(this.enabled);
this._peopleIdentify();
// }
if (!__DEV__) {
RCTAnalytics.optIn(this.enabled);
this._peopleIdentify();
}
}
return Analytics.instance;
}
Expand Down
57 changes: 28 additions & 29 deletions app/util/analytics.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,21 +110,7 @@ const NAMES = {
WALLET_BUY_ETH: 'Buy ETH',
PAYMENTS_SELECTS_DEBIT_OR_ACH: 'Selects debit card or bank account as payment method',
PAYMENTS_SELECTS_APPLE_PAY: 'Selects Apple Pay as payment method',

// Swaps
SWAPS_OPENED: 'Swaps Opened',
SWAP_TRACKING_FAILED: 'Swap Tracking failed',
QUOTES_REQUESTED: 'Quotes Requested',
QUOTES_RECEIVED: 'Quotes Received',
QUOTES_REQUEST_CANCELLED: 'Quotes Request Cancelled',
ALL_AVAILABLE_QUOTES_OPENED: 'All Available Quotes Opened',
SWAP_STARTED: 'Swap Started',
SWAP_COMPLETED: 'Swap Completed',
SWAP_FAILED: 'Swap Failed',
QUOTES_TIMED_OUT: 'Quotes Timed Out',
NO_QUOTES_AVAILABLE: 'No Quotes Available',
GAS_FEES_CHANGED: 'Gas Fees Changed',
EDIT_SPEND_LIMIT_OPENED: 'Edit Spend Limit Opened'
SWAPS: 'Swaps'
};

const ACTIONS = {
Expand Down Expand Up @@ -190,7 +176,20 @@ const CATEGORIES = {
DAPP_INTERACTIONS: 'Dapp Interactions',
WALLET: 'Wallet',
PAYMENTS: 'Payments',
SWAPS: 'Swaps'
// Swaps
SWAPS_OPENED: 'Swaps Opened',
SWAP_TRACKING_FAILED: 'Swap Tracking Failed',
QUOTES_REQUESTED: 'Quotes Requested',
QUOTES_RECEIVED: 'Quotes Received',
QUOTES_REQUEST_CANCELLED: 'Quotes Request Cancelled',
ALL_AVAILABLE_QUOTES_OPENED: 'All Available Quotes Opened',
SWAP_STARTED: 'Swap Started',
SWAP_COMPLETED: 'Swap Completed',
SWAP_FAILED: 'Swap Failed',
QUOTES_TIMED_OUT: 'Quotes Timed Out',
NO_QUOTES_AVAILABLE: 'No Quotes Available',
GAS_FEES_CHANGED: 'Gas Fees Changed',
EDIT_SPEND_LIMIT_OPENED: 'Edit Spend Limit Opened'
};

export const ANALYTICS_EVENT_OPTS = {
Expand Down Expand Up @@ -514,17 +513,17 @@ export const ANALYTICS_EVENT_OPTS = {
NAMES.PAYMENTS_SELECTS_APPLE_PAY
),
// Swaps
SWAPS_OPENED: generateOpt(CATEGORIES.SWAPS, ACTIONS.SWAP, NAMES.SWAPS_OPENED),
QUOTES_REQUESTED: generateOpt(CATEGORIES.SWAPS, ACTIONS.QUOTE, NAMES.QUOTES_REQUESTED),
QUOTES_RECEIVED: generateOpt(CATEGORIES.SWAPS, ACTIONS.QUOTE, NAMES.QUOTES_RECEIVED),
QUOTES_REQUEST_CANCELLED: generateOpt(CATEGORIES.SWAPS, ACTIONS.QUOTE, NAMES.QUOTES_REQUEST_CANCELLED),
ALL_AVAILABLE_QUOTES_OPENED: generateOpt(CATEGORIES.SWAPS, ACTIONS.QUOTE, NAMES.ALL_AVAILABLE_QUOTES_OPENED),
SWAP_STARTED: generateOpt(CATEGORIES.SWAPS, ACTIONS.SWAP, NAMES.SWAP_STARTED),
SWAP_COMPLETED: generateOpt(CATEGORIES.SWAPS, ACTIONS.SWAP, NAMES.SWAP_COMPLETED),
SWAP_FAILED: generateOpt(CATEGORIES.SWAPS, ACTIONS.SWAP, NAMES.SWAP_FAILED),
SWAP_TRACKING_FAILED: generateOpt(CATEGORIES.SWAPS, ACTIONS.SWAP, NAMES.SWAP_TRACKING_FAILED),
QUOTES_TIMED_OUT: generateOpt(CATEGORIES.SWAPS, ACTIONS.QUOTE, NAMES.QUOTES_TIMED_OUT),
NO_QUOTES_AVAILABLE: generateOpt(CATEGORIES.SWAPS, ACTIONS.QUOTE, NAMES.NO_QUOTES_AVAILABLE),
GAS_FEES_CHANGED: generateOpt(CATEGORIES.SWAPS, ACTIONS.QUOTE, NAMES.GAS_FEES_CHANGED),
EDIT_SPEND_LIMIT_OPENED: generateOpt(CATEGORIES.SWAPS, ACTIONS.QUOTE, NAMES.EDIT_SPEND_LIMIT_OPENED)
SWAPS_OPENED: generateOpt(CATEGORIES.SWAPS_OPENED, ACTIONS.SWAP, NAMES.SWAPS),
QUOTES_REQUESTED: generateOpt(CATEGORIES.QUOTES_REQUESTED, ACTIONS.QUOTE, NAMES.SWAPS),
QUOTES_RECEIVED: generateOpt(CATEGORIES.QUOTES_RECEIVED, ACTIONS.QUOTE, NAMES.SWAPS),
QUOTES_REQUEST_CANCELLED: generateOpt(CATEGORIES.QUOTES_REQUEST_CANCELLED, ACTIONS.QUOTE, NAMES.SWAPS),
ALL_AVAILABLE_QUOTES_OPENED: generateOpt(CATEGORIES.ALL_AVAILABLE_QUOTES_OPENED, ACTIONS.QUOTE, NAMES.SWAPS),
SWAP_STARTED: generateOpt(CATEGORIES.SWAP_STARTED, ACTIONS.SWAP, NAMES.SWAPS),
SWAP_COMPLETED: generateOpt(CATEGORIES.SWAP_COMPLETED, ACTIONS.SWAP, NAMES.SWAPS),
SWAP_FAILED: generateOpt(CATEGORIES.SWAP_FAILED, ACTIONS.SWAP, NAMES.SWAPS),
SWAP_TRACKING_FAILED: generateOpt(CATEGORIES.SWAP_TRACKING_FAILED, ACTIONS.SWAP, NAMES.SWAPS),
QUOTES_TIMED_OUT: generateOpt(CATEGORIES.QUOTES_TIMED_OUT, ACTIONS.QUOTE, NAMES.SWAPS),
NO_QUOTES_AVAILABLE: generateOpt(CATEGORIES.NO_QUOTES_AVAILABLE, ACTIONS.QUOTE, NAMES.SWAPS),
GAS_FEES_CHANGED: generateOpt(CATEGORIES.GAS_FEES_CHANGED, ACTIONS.QUOTE, NAMES.SWAPS),
EDIT_SPEND_LIMIT_OPENED: generateOpt(CATEGORIES.EDIT_SPEND_LIMIT_OPENED, ACTIONS.QUOTE, NAMES.SWAPS)
};