Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update terms and privacy links #2443

Merged
merged 6 commits into from
Mar 31, 2021
Merged

Update terms and privacy links #2443

merged 6 commits into from
Mar 31, 2021

Conversation

estebanmino
Copy link
Contributor

Description

Write a short description of the changes included in this pull request.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #2436

@estebanmino estebanmino requested a review from a team as a code owner March 29, 2021 16:02
@estebanmino estebanmino added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. next release labels Mar 29, 2021
rickycodes
rickycodes approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@rickycodes rickycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ibrahimtaveras00
ibrahimtaveras00 suggested changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tap here on wallet setup view, nothing happens

image

nonetheless the same link on the import seedphrase works

@ibrahimtaveras00 ibrahimtaveras00 added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Mar 30, 2021
@estebanmino
Copy link
Contributor Author

@ibrahimtaveras00 this was included in #2176 but I just fixed it

@estebanmino estebanmino added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Mar 30, 2021
ibrahimtaveras00
ibrahimtaveras00 approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work now on a fresh install = https://recordit.co/6kcrEtsDdg

However, it still doesn't work after you delete your wallet, and attempt to open terms and conditions on wallet setup view. I opened another issue though since this is outside the scope of this PR, found here = #2462

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Mar 30, 2021
@estebanmino estebanmino merged commit c477fde into develop Mar 31, 2021
@estebanmino estebanmino deleted the update-links branch March 31, 2021 17:31
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
Update terms and privacy links (#2443)
2cb357d 
* TERMS_AND_CONDITIONS

* PRIVACY_POLICY

* PRIVACY_POLICY

* fixcomponent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickycodes rickycodes rickycodes approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update links to Privacy policy and Terms of Use
3 participants
@estebanmino @rickycodes @ibrahimtaveras00