-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check infura availability #2520
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as mentioned in the chat I don't think we need ios/Podfile.lock changes
and i think snapshots need to be updated, but otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're good to go |
app/components/Nav/Main/index.js
Outdated
await util.query(TransactionController.ethQuery, 'blockNumber', []); | ||
props.setInfuraAvailabilityNotBlocked(); | ||
} catch (e) { | ||
if (e?.message === AppConstants.ERRORS.INFURA_BLOCKED_MESSAGE) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't need ?
here. .message
will evaluate to undefined
if it's not set in this case since it's top level.
* addcheck * component * componentUI * checkProviderStatus * log * finalstyle * locales * tryagain * snapshots * checkInfuraAvailability * updatecopy * handleinfura * tests * CONNECTIVITY_ISSUESlink * copy * copy * translations * e * check * test
* addcheck * component * componentUI * checkProviderStatus * log * finalstyle * locales * tryagain * snapshots * checkInfuraAvailability * updatecopy * handleinfura * tests * CONNECTIVITY_ISSUESlink * copy * copy * translations * e * check * test
Description
Waiting for
Checklist
Issue
Resolves https://github.com/MetaMask/mobile-planning/issues/86