Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Send Feedback to Request a Feature and update link #2536

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Change Send Feedback to Request a Feature and update link #2536

merged 2 commits into from
Apr 15, 2021

Conversation

rickycodes
Copy link
Member

Description

Before:

image

image

After:

image

image

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #2473

@rickycodes rickycodes requested a review from a team as a code owner April 15, 2021 17:55
@rickycodes rickycodes added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 15, 2021
andrepimenta
andrepimenta approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@andrepimenta andrepimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ibrahimtaveras00
ibrahimtaveras00 approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed 👍🏽

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 15, 2021
@rickycodes rickycodes merged commit ed3d850 into develop Apr 15, 2021
@rickycodes rickycodes deleted the feature/appropriate-support branch April 15, 2021 20:42
@rickycodes rickycodes removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 15, 2021
@rickycodes rickycodes mentioned this pull request May 4, 2021
Closed
rickycodes added a commit that referenced this pull request Jan 31, 2022
@rickycodes
Change Send Feedback to Request a Feature and update link (#2536)
fb16a8a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrepimenta andrepimenta andrepimenta approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Direct people correctly to find appropriate support
3 participants
@rickycodes @andrepimenta @ibrahimtaveras00