Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/connection change handler #2538

Merged
merged 5 commits into from
Apr 16, 2021
Merged

fix/connection change handler #2538

merged 5 commits into from
Apr 16, 2021

Conversation

estebanmino
Copy link
Contributor

Description

Write a short description of the changes included in this pull request.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@estebanmino estebanmino requested a review from a team as a code owner April 16, 2021 13:39
@estebanmino estebanmino changed the base branch from develop to main April 16, 2021 14:37
@estebanmino estebanmino changed the base branch from main to develop April 16, 2021 14:37
@ibrahimtaveras00 ibrahimtaveras00 added the QA in Progress QA has started on the feature. label Apr 16, 2021
ibrahimtaveras00
ibrahimtaveras00 approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed 👍🏽

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Apr 16, 2021
@estebanmino estebanmino merged commit 86771f7 into develop Apr 16, 2021
@estebanmino estebanmino deleted the connection-change-handler branch April 16, 2021 16:31
estebanmino added a commit that referenced this pull request Apr 16, 2021
@estebanmino
fix/connection change handler (#2538)
9ae7de2 
* additionalchecks

* rm

* setConnected

* false

* null
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
fix/connection change handler (#2538)
dec1728 
* additionalchecks

* rm

* setConnected

* false

* null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees

@estebanmino estebanmino

Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estebanmino @ibrahimtaveras00