Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix/sync import time #2554

Merged
merged 4 commits into from
Apr 20, 2021
Merged

Bug fix/sync import time #2554

merged 4 commits into from
Apr 20, 2021

Conversation

sethkfman
Copy link
Contributor

Description

Bug fix to display sync/add account time in txs view when syncing.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #2460

@sethkfman sethkfman requested a review from a team as a code owner April 20, 2021 19:25
@sethkfman sethkfman added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 20, 2021
@ibrahimtaveras00 ibrahimtaveras00 added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 20, 2021
rickycodes
rickycodes approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@rickycodes rickycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ibrahimtaveras00
ibrahimtaveras00 approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed 👍🏽

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Apr 20, 2021
@sethkfman sethkfman merged commit 0c294f2 into develop Apr 20, 2021
@sethkfman sethkfman deleted the bug_fix/sync_import_time branch April 20, 2021 20:22
rickycodes added a commit that referenced this pull request Apr 21, 2021
@rickycodes
Merge branch 'fix/edit-permission-initial-state' of github.com:MetaMa…
ad8c929 
…sk/metamask-mobile into fix/edit-permission-initial-state

* 'fix/edit-permission-initial-state' of github.com:MetaMask/metamask-mobile:
  Bump versioncode (#2558)
  v2.2.0 (#2555)
  Include decimalsToShow in balanceToFiatNumber (#2547)
  Bug fix/sync import time (#2554)
  bundle update (#2549)
rickycodes added a commit to ScreamingHawk/metamask-mobile that referenced this pull request Apr 30, 2021
@rickycodes
Merge branch 'develop' of github.com:MetaMask/metamask-mobile into pa…
5242665 
…tch-1

* 'develop' of github.com:MetaMask/metamask-mobile: (51 commits)
  Feature/confusables (MetaMask#2464)
  fix typeface on login text field (MetaMask#2610)
  Replace controller context (MetaMask#2416)
  Fix adding custom token in custom network (MetaMask#2590)
  only add custom tokens if not in mainnet (MetaMask#2470)
  Address yarn lints (MetaMask#2524)
  Upgrade .nvmrc to node v14 (MetaMask#2588)
  Swaps: Add cache thresholds configuration (MetaMask#2514)
  Swaps: BSC Support (MetaMask#2468)
  Use node 14 (MetaMask#2539)
  resolve isENS without case sensitivity (MetaMask#2545) (MetaMask#2568)
  Revert "resolve isENS without case sensitivity (MetaMask#2545)" (MetaMask#2566)
  resolve isENS without case sensitivity (MetaMask#2545)
  Bump versioncode (MetaMask#2558)
  v2.2.0 (MetaMask#2555)
  Include decimalsToShow in balanceToFiatNumber (MetaMask#2547)
  Bug fix/sync import time (MetaMask#2554)
  bundle update (MetaMask#2549)
  Fix analytics try catch (MetaMask#2546)
  Only get nonce from the network if the feature is enabled (MetaMask#2543)
  ...
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@sethkfman
Bug fix/sync import time (#2554)
54de5df 
* added sort order on transactions before filtering

* added import date to preferences coming from sync data of the extension

* correct variable spelling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickycodes rickycodes rickycodes approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sethkfman @rickycodes @ibrahimtaveras00