Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notification fix attempt #2687

Merged
merged 6 commits into from
May 17, 2021
Merged

notification fix attempt #2687

merged 6 commits into from
May 17, 2021

Conversation

estebanmino
Copy link
Contributor

@estebanmino estebanmino commented May 14, 2021 •
edited
Loading

Description

Write a short description of the changes included in this pull request.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #2494

@estebanmino estebanmino requested a review from a team as a code owner May 14, 2021 16:32
@estebanmino estebanmino added needs-design Feature that requires UI/UX design needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-design Feature that requires UI/UX design labels May 14, 2021
@mobularay mobularay linked an issue May 17, 2021 that may be closed by this pull request
Transaction Notification stuck at the bottom of the screen. #2494
Closed
@ibrahimtaveras00 ibrahimtaveras00 added the QA in Progress QA has started on the feature. label May 17, 2021
@mobularay
Copy link
Contributor

Team has decided to follow the normal release process. ETA to roll-out to production is next week (proposing Tuesday May 27 since many team members are away on May 26) , if all goes well with testing and validation.

ibrahimtaveras00
ibrahimtaveras00 approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed on both emulators/simulators and on real devices on both OS's 👍🏽

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels May 17, 2021
@estebanmino estebanmino merged commit 04d636c into develop May 17, 2021
@estebanmino estebanmino deleted the notification-fix-attempt branch May 17, 2021 21:24
@estebanmino estebanmino mentioned this pull request Jun 3, 2021
Merged
3 tasks
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
bufix: stuck notification (#2687)
20235a5 
* hideCurrentNotification

* thinkisfixed

* removenotvisiblenots

* checkarray
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@wachunei wachunei wachunei approved these changes

@rickycodes rickycodes rickycodes approved these changes

Assignees

@estebanmino estebanmino

Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transaction Notification stuck at the bottom of the screen.
5 participants
@estebanmino @mobularay @rickycodes @wachunei @ibrahimtaveras00