Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom gas crash #2692

Merged
merged 2 commits into from
May 20, 2021
Merged

Fix custom gas crash #2692

merged 2 commits into from
May 20, 2021

Conversation

wachunei
Copy link
Member

Issue

Resolves #2690

@wachunei wachunei requested a review from a team as a code owner May 17, 2021 17:04
@mobularay mobularay added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels May 17, 2021
@mobularay mobularay mentioned this pull request May 17, 2021
Closed
andrepimenta
andrepimenta approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@andrepimenta andrepimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@andrepimenta andrepimenta removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 19, 2021
ibrahimtaveras00
ibrahimtaveras00 approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels May 20, 2021
@wachunei wachunei merged commit b59aaed into develop May 20, 2021
@wachunei wachunei deleted the fix/custom-gas-crash branch May 20, 2021 16:50
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@wachunei
Fix custom gas crash (#2692)
5e532c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrepimenta andrepimenta andrepimenta approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees

@wachunei wachunei

Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding decimals to gas calculation crashes MetaMask
5 participants
@wachunei @andrepimenta @ibrahimtaveras00 @estebanmino @mobularay