Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swaps: Add chainId to swaps analytics #2694

Merged
merged 2 commits into from
May 18, 2021
Merged

Conversation

wachunei
Copy link
Member

Description

This PR adds chain_id to swaps analytics data.

@wachunei wachunei requested a review from a team as a code owner May 17, 2021 21:43
@wachunei wachunei changed the title Add chainId to swaps analytics Swaps: Add chainId to swaps analytics May 17, 2021
@wachunei wachunei added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 17, 2021
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 18, 2021
@wachunei wachunei merged commit 82140c2 into develop May 18, 2021
@wachunei wachunei deleted the refactor/swaps-track-chainid branch May 18, 2021 14:58
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants