Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swaps: Add custom token flow - search by address and get it imported to your wallet #2729

Merged
merged 17 commits into from
Jul 27, 2021
Merged

Swaps: Add custom token flow - search by address and get it imported to your wallet #2729

merged 17 commits into from
Jul 27, 2021

Conversation

wachunei
Copy link
Member

Description

This PR allows a user to enter a custom token address and use it to Swap

Issue

Resolves #2641

@wachunei wachunei self-assigned this May 28, 2021
@wachunei wachunei added the swaps MetaSwaps issues label May 28, 2021
@wachunei wachunei marked this pull request as ready for review June 1, 2021 20:50
@wachunei wachunei requested a review from a team as a code owner June 1, 2021 20:50
@wachunei wachunei added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 1, 2021
@sethkfman sethkfman self-requested a review June 2, 2021 00:44
@mobularay mobularay added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jun 3, 2021
sethkfman
sethkfman approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mobularay mobularay removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 4, 2021
@mobularay mobularay added the design-review Any feature that needs feedback from the design team label Jun 23, 2021
@mobularay mobularay changed the title Swaps: Add custom token flow Swaps: Add custom token flow - search by address and get it imported to your wallet Jun 23, 2021
@mobularay
Copy link
Contributor

@jakehaugen: I just added the "design-qa" label

@ibrahimtaveras00 ibrahimtaveras00 removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jul 26, 2021
@ibrahimtaveras00 ibrahimtaveras00 added the QA in Progress QA has started on the feature. label Jul 26, 2021
ibrahimtaveras00
ibrahimtaveras00 suggested changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue 1:

it’s a bit tight to scroll on small device to see the full “can’t find a token” message box
http://recordit.co/Qd3Qsgce0D

Issue 2:

when you tap on the bscscan link it takes you to a 403 = http://recordit.co/zb2ZWCDbKK

I searched this token = 0x170dca460d661e834ff91bf6011afa8aa1a00b05

@ibrahimtaveras00 ibrahimtaveras00 added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed QA in Progress QA has started on the feature. labels Jul 26, 2021
@wachunei wachunei added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jul 27, 2021
@jakehaugen
Copy link
Contributor

Issue 1:

it’s a bit tight to scroll on small device to see the full “can’t find a token” message box
http://recordit.co/Qd3Qsgce0D

No idea why this would cause a scrolling issue. Are design changes needed?

@wachunei
Copy link
Member Author

@jakehaugen I fixed it, no design changes needed. The issue happened because the footer was a regular view that did not capture the scrolling gesture. I changed it to a Touchable (without feedback) and behaves correctly now.

@ibrahimtaveras00 ibrahimtaveras00 added QA in Progress QA has started on the feature. and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 27, 2021
ibrahimtaveras00
ibrahimtaveras00 approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes look good, QA Passed 👍🏽

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Jul 27, 2021
@wachunei wachunei merged commit feb9df0 into develop Jul 27, 2021
@wachunei wachunei deleted the feature/swaps-custom-token branch July 27, 2021 17:45
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@wachunei
Swaps: Add custom token flow - search by address and get it imported …
94a9738 
…to your wallet (#2729)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethkfman sethkfman sethkfman approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees

@wachunei wachunei

Labels
design-review Any feature that needs feedback from the design team QA Passed A successful QA run through has been done swaps MetaSwaps issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Swaps: Custom Token Flow - search by address and get it imported to your wallet
5 participants
@wachunei @mobularay @jakehaugen @sethkfman @ibrahimtaveras00