Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for speedUp in transaction list #2909

Merged
merged 4 commits into from
Jul 27, 2021
Merged

Account for speedUp in transaction list #2909

merged 4 commits into from
Jul 27, 2021

Conversation

rickycodes
Copy link
Member

Description

Write a short description of the changes included in this pull request.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@rickycodes rickycodes requested a review from a team as a code owner July 16, 2021 18:02
@rickycodes rickycodes added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 16, 2021
@rickycodes rickycodes changed the title Account for speedUp Account for speedUp in transaction list Jul 20, 2021
andrepimenta
andrepimenta approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@andrepimenta andrepimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrepimenta andrepimenta removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 20, 2021
@mobularay mobularay mentioned this pull request Jul 20, 2021
Closed
4 tasks
@ibrahimtaveras00 ibrahimtaveras00 added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 27, 2021
@rickycodes
Copy link
Member Author

I'm including a whole whack of yarn lockfile removals because our yarn lock file was out of sync

ibrahimtaveras00
ibrahimtaveras00 approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed 👍🏽

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Jul 27, 2021
@rickycodes rickycodes merged commit 1730c0e into develop Jul 27, 2021
@rickycodes rickycodes deleted the bugfix/account-for-speedUp branch July 27, 2021 20:52
rickycodes added a commit that referenced this pull request Jan 31, 2022
@rickycodes
Account for speedUp in transaction list (#2909)
5d3a5a7 
* Account for speedUps

* filter speedUps from Asset view as well

* update lockfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrepimenta andrepimenta andrepimenta approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees

@rickycodes rickycodes

Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rickycodes @andrepimenta @ibrahimtaveras00