Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Transaction state #3099

Merged
merged 9 commits into from
Sep 9, 2021
Merged

[FEATURE] Transaction state #3099

merged 9 commits into from
Sep 9, 2021

Conversation

gantunesr
Copy link
Member

Improvement on how we process transaction state by updating the Transaction Controller. The extension currently has a Transaction State Controller to handle user scenarios, something we lack.

@gantunesr gantunesr requested a review from a team September 7, 2021 15:45
@gantunesr gantunesr self-assigned this Sep 7, 2021
@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Sep 7, 2021
@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Sep 7, 2021
cortisiko
cortisiko approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't notice nothing out of the ordinary here. 💯

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Sep 7, 2021
rickycodes
rickycodes requested changes Sep 9, 2021
View reviewed changes
Copy link
Member

@rickycodes rickycodes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one small thing

nvm

@gantunesr gantunesr merged commit 12e0987 into develop Sep 9, 2021
@gantunesr gantunesr deleted the feat/tx-state branch September 9, 2021 16:58
@gantunesr gantunesr mentioned this pull request Jan 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickycodes rickycodes rickycodes approved these changes

@cortisiko cortisiko cortisiko approved these changes

Assignees

@gantunesr gantunesr

Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gantunesr @rickycodes @cortisiko