Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add opt in event #3130

Merged
merged 4 commits into from
Sep 21, 2021
Merged

Re-add opt in event #3130

merged 4 commits into from
Sep 21, 2021

Conversation

gantunesr
Copy link
Member

As part of 2994, Lorenzo requested to re-add the ONBOARDING_METRICS_OPT_IN event.

@gantunesr gantunesr requested a review from a team as a code owner September 15, 2021 23:20
@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. labels Sep 15, 2021
sethkfman
sethkfman reviewed Sep 21, 2021
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just would like clarification on one item.

app/components/UI/OptinMetrics/index.js Show resolved Hide resolved
sethkfman
sethkfman approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr merged commit 00f70cc into develop Sep 21, 2021
@gantunesr gantunesr deleted the fix/revert-opt-in-event branch September 21, 2021 17:26
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
Re-add opt in event (#3130)
7228654
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gantunesr @sethkfman