Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reload when switching networks on the browser #3133

Merged
merged 4 commits into from
Sep 23, 2021
Merged

Fix reload when switching networks on the browser #3133

merged 4 commits into from
Sep 23, 2021

Conversation

andrepimenta
Copy link
Member

@andrepimenta andrepimenta commented Sep 16, 2021 •
edited
Loading

Description

This PR fixes the reload when switching networks on the browser.

Issue

Resolves #3078

@andrepimenta andrepimenta requested a review from a team as a code owner September 16, 2021 12:45
@andrepimenta andrepimenta added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Sep 16, 2021
gantunesr
gantunesr reviewed Sep 17, 2021
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a question regarding the Podfile

ios/Podfile.lock Outdated Show resolved Hide resolved
@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Sep 21, 2021
cortisiko
cortisiko approved these changes Sep 22, 2021
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🌮

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Sep 22, 2021
Cal-L
Cal-L approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrepimenta andrepimenta merged commit 095c70e into develop Sep 23, 2021
@andrepimenta andrepimenta deleted the fix/switch-network-browser branch September 23, 2021 12:58
@cortisiko cortisiko mentioned this pull request Sep 27, 2021
Closed
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@andrepimenta
Fix reload when switching networks on the browser (#3133)
0fe4651 
* Fix reload when switching networks on the browser

* Move to one line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cal-L Cal-L Cal-L approved these changes

@cortisiko cortisiko cortisiko approved these changes

@gantunesr gantunesr Awaiting requested review from gantunesr

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On switching account, network - the browser (and site) doesn't update right away
4 participants
@andrepimenta @Cal-L @cortisiko @gantunesr