Bug/3137 token address crasher #3152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cal-L
added
No QA Needed
gantunesr
reviewed
Sep 21, 2021
Comment on lines
79
to
83
| try { | ||
| await TokensController.addToken(address, symbol, decimals); | ||
| } catch (error) { | ||
| Logger.log('Error while trying to add a custom token', error); | ||
| } |
There was a problem hiding this comment.
Do you think it would be better to create a method in a utils file since you use this code in multiple parts?
app/store/migrations.js
Outdated
Comment on lines
215
to
228
| const newAllTokens = {}; | ||
| Object.entries(allTokens).forEach(([chainId, tokensByAccountAddress]) => { | ||
| Object.entries(tokensByAccountAddress).forEach(([accountAddress, tokens]) => { | ||
| const newTokens = tokens.filter(({ address }) => !!address); | ||
| if (newAllTokens[chainId] === undefined) { | ||
| newAllTokens[chainId] = { [accountAddress]: newTokens }; | ||
| } else { | ||
| newAllTokens[chainId] = { | ||
| ...newAllTokens[chainId], | ||
| [accountAddress]: newTokens, | ||
| }; | ||
| } | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Seems like this logic its the same as the one between lines 229-242, it could be transferred to a new method to avoid repetition.
Cal-L
removed
No QA Needed
Cal-L
added
needs-dev-review
Cal-L
removed
the
needs-dev-review
Cal-L
removed
the
No QA Needed
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* Filter out tokens with missing address in migration. Catch and log token removal action. * Attempt to catch and log failures when adding token * Remove puncuations from removal error message * Update migration * Clean up migration to only apply for ignored tokens. Map into array of strings * Revert "Attempt to catch and log failures when adding token" This reverts commit 7e2752e. * Update remove token catch log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#3137
Checklist
Issue
Resolves #???