Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inject favourites homepage #3153

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Fix inject favourites homepage #3153

merged 2 commits into from
Sep 21, 2021

Conversation

andrepimenta
Copy link
Member

Description

Write a short description of the changes included in this pull request.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@andrepimenta andrepimenta requested a review from a team as a code owner September 21, 2021 10:30
@andrepimenta andrepimenta added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Sep 21, 2021
gantunesr
gantunesr approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 21, 2021
@cortisiko cortisiko linked an issue Sep 21, 2021 that may be closed by this pull request
Browser favorites is broken on iOS #3151
Closed
@cortisiko cortisiko self-assigned this Sep 21, 2021
@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Sep 21, 2021
@cortisiko cortisiko assigned andrepimenta and unassigned cortisiko Sep 21, 2021
cortisiko
cortisiko approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 🌮 🌮 🌮 🌮 🌮

@andrepimenta andrepimenta merged commit 4470118 into develop Sep 21, 2021
@andrepimenta andrepimenta deleted the fix/inject-favourites-homepage branch September 21, 2021 15:47
@mobularay mobularay mentioned this pull request Sep 27, 2021
Closed
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@andrepimenta
Fix inject favourites homepage (#3153)
375f02b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees

@andrepimenta andrepimenta

Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Browser favorites is broken on iOS
3 participants
@andrepimenta @cortisiko @gantunesr