Fix send network change update to websites #3211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrepimenta
added
needs-dev-review
andrepimenta
changed the title
rickycodes
approved these changes
Sep 29, 2021
rickycodes
reviewed
Sep 29, 2021
| @@ -118,13 +119,18 @@ export class BackgroundBridge extends EventEmitter { | |||
| const publicState = this.getProviderNetworkState(memState); | |||
There was a problem hiding this comment.
nit: we could destructure here
Suggested change
| const publicState = this.getProviderNetworkState(memState); | |
| const { chainId, networkVersion } = this.getProviderNetworkState(memState); |
and then just refer to those instead
cortisiko
added
QA Passed
cortisiko
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reflect network change on websites. This PR changes some of the logic about when we send a network update the websites.
Checklist
Issue
Resolves #???