Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Turn off token detection by default #3260

Merged
merged 4 commits into from
Oct 5, 2021
Merged

[FIX] Turn off token detection by default #3260

merged 4 commits into from
Oct 5, 2021

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Oct 5, 2021

Description

#3259

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@Cal-L Cal-L requested a review from a team as a code owner October 5, 2021 03:06
@Cal-L Cal-L added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 5, 2021
@Cal-L Cal-L self-assigned this Oct 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2021 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added the No QA Needed Apply this label when your PR does not need any QA effort. label Oct 5, 2021
@Cal-L Cal-L changed the title Update migration to turn off token detection [FIX] Turn off token detection by default Oct 5, 2021
gantunesr
gantunesr reviewed Oct 5, 2021
View reviewed changes
app/core/Engine.js Outdated Show resolved Hide resolved
@Cal-L
Simplify logic
285ca57 
Co-authored-by: Gustavo Antunes <gantunes@uc.cl>
gantunesr
gantunesr approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L merged commit 12a1c2b into develop Oct 5, 2021
@Cal-L Cal-L deleted the fix/3259-turn-off-token-detection branch October 5, 2021 18:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr approved these changes

Assignees

@Cal-L Cal-L

Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cal-L @gantunesr