Populate block number #3265
Merged
Populate block number #3265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrepimenta
added
needs-dev-review
rickycodes
approved these changes
Oct 6, 2021
andrepimenta
added
needs-qa
cortisiko
added
QA in Progress
cortisiko
added
QA Passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For rpc methods like
eth_getCode, a lot of dapps don't send the blockNumber argument even though it's required. In order to fix this, we are populating this argument with 'latest'. This is being done in an effort to clean sentry logs from this error.Check extension for similar implementation: https://github.com/MetaMask/eth-json-rpc-middleware/blob/main/src/block-ref.ts#L53
How to test:
Just test as many dapps as possible on different networks, including custom networks, and see if they are all working correctly.
Issue
Resolves #3264