Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add analytics for android keystore #3292

Merged
merged 8 commits into from
Oct 18, 2021
Merged

[FEATURE] Add analytics for android keystore #3292

merged 8 commits into from
Oct 18, 2021

Conversation

sethkfman
Copy link
Contributor

Description

Added analytics to confirm the number of users we have with Android Hardware Backed Keystores

Checklist

  • [NA] There is a related GitHub issue
  • [NA] Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #3287

@sethkfman sethkfman requested a review from a team as a code owner October 12, 2021 21:28
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman changed the title Feature/analytics keystore [FEATURE] Add analytics for android keystore Oct 12, 2021
@sethkfman sethkfman added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 12, 2021
rickycodes
rickycodes approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@rickycodes rickycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman merged commit b2eb1bd into develop Oct 18, 2021
@sethkfman sethkfman deleted the feature/analytics-keystore branch October 18, 2021 18:31
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rickycodes rickycodes rickycodes approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Analytics: Android Hardware Backed Keystore
2 participants
@sethkfman @rickycodes