Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/3202 invisible android text input #3294

Merged
merged 3 commits into from
Oct 14, 2021
Merged

Fix/3202 invisible android text input #3294

merged 3 commits into from
Oct 14, 2021

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Oct 13, 2021 •
edited
Loading

Description

Only set no keyboard learning flag on non-Samsung devices. This will apply to devices that mostly use Google's Keyboard or Gboard. Samsung keyboards do not support incognito mode.

#3202

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@Cal-L Cal-L requested a review from a team as a code owner October 13, 2021 02:22
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Oct 13, 2021
@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Oct 13, 2021
cortisiko
cortisiko approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Oct 13, 2021
gantunesr
gantunesr approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Cal-L Cal-L merged commit 4f90828 into develop Oct 14, 2021
@Cal-L Cal-L deleted the fix/3202-invisible-android-text-input branch October 14, 2021 02:02
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2021
@Cal-L Cal-L removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cal-L @cortisiko @gantunesr