Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions #3298

Merged
merged 3 commits into from
Oct 20, 2021
Merged

GitHub Actions #3298

merged 3 commits into from
Oct 20, 2021

Conversation

rickycodes
Copy link
Member

@rickycodes rickycodes commented Oct 15, 2021 •
edited
Loading

Description

This moves ci step into github actions for all to see: https://github.com/MetaMask/metamask-mobile/actions/runs/1346447167

(the bitrise build is going to run forever because i removed the triggers)

Checklist

  • get build, lint, audit and test jobs working via github actions
  • remove triggers for bitrise

@rickycodes rickycodes requested a review from a team as a code owner October 15, 2021 15:29
sethkfman
sethkfman approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickycodes rickycodes merged commit ff66733 into develop Oct 20, 2021
@rickycodes rickycodes deleted the feature/github-actions branch October 20, 2021 15:30
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rickycodes @sethkfman