Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude PhishingController state from persist #3340

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Exclude PhishingController state from persist #3340

merged 2 commits into from
Oct 26, 2021

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Oct 26, 2021

Description

#3339

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@Cal-L Cal-L requested a review from a team as a code owner October 26, 2021 03:11
@Cal-L Cal-L added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. labels Oct 26, 2021
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

sethkfman
sethkfman approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L merged commit f7a5b0d into develop Oct 26, 2021
@Cal-L Cal-L deleted the improvement/3339-exclude-phishing-from-persist branch October 26, 2021 16:35
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2021
@Cal-L Cal-L removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cal-L @sethkfman