Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NFTs ipfs support #3343

Merged
merged 9 commits into from
Oct 29, 2021
Merged

Add NFTs ipfs support #3343

merged 9 commits into from
Oct 29, 2021

Conversation

wachunei
Copy link
Member

⚠️ Blocked by

Description
This PR adds NFT ipfs image support

TODO

  • Remove controllers package

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #3310

@gantunesr
Copy link
Member

Blocked by #3301

@wachunei wachunei marked this pull request as ready for review October 28, 2021 14:40
@wachunei wachunei requested a review from a team as a code owner October 28, 2021 14:40
cortisiko
cortisiko approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🌮 🌮

@cortisiko cortisiko added the QA Passed A successful QA run through has been done label Oct 28, 2021
gantunesr
gantunesr approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr mentioned this pull request Oct 29, 2021
Closed
@wachunei wachunei merged commit 12aa990 into develop Oct 29, 2021
@wachunei wachunei deleted the feature/nft-ipfs-support branch October 29, 2021 19:28
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for IPFS on NFTs
3 participants
@wachunei @gantunesr @cortisiko