Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Transaction Review - View Data Not Displaying #3352

Merged
merged 3 commits into from
Oct 29, 2021
Merged

[FIX] Transaction Review - View Data Not Displaying #3352

merged 3 commits into from
Oct 29, 2021

Conversation

sethkfman
Copy link
Contributor

Description

The animations used to show View Data relied on the CustomGas Component's height to establish the display heights for other components like View Data. A hardcoded height was set for a temporary fix until we can refactor the animation component.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@sethkfman sethkfman requested a review from a team as a code owner October 29, 2021 01:32
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman self-assigned this Oct 29, 2021
@sethkfman sethkfman added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. type-bug Something isn't working labels Oct 29, 2021
Cal-L
Cal-L approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cortisiko
cortisiko approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🌮

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Oct 29, 2021
@sethkfman sethkfman merged commit c15b5b5 into develop Oct 29, 2021
@sethkfman sethkfman deleted the fix/view-data-not-displaying branch October 29, 2021 19:15
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

@cortisiko cortisiko cortisiko approved these changes

Assignees

@sethkfman sethkfman

Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) QA Passed A successful QA run through has been done type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sethkfman @Cal-L @cortisiko