Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] iOS FaceID Deny Handler #3371

Merged
merged 6 commits into from
Nov 16, 2021
Merged

[FIX] iOS FaceID Deny Handler #3371

merged 6 commits into from
Nov 16, 2021

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Nov 3, 2021

Description

Added graceful handling if a user disables FaceID during wallet creation. This allows a user to decline the OS level request and still create a wallet.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #3358

@sethkfman sethkfman requested a review from a team as a code owner November 3, 2021 21:06
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 3, 2021
@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 4, 2021
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🌮 🌮 🌮

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Nov 4, 2021
@sethkfman sethkfman changed the title added method to catch deny biometric pop-up and reset view iOS Biometric Deny Handler Nov 5, 2021
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC: @sethkfman Left some comments

app/components/Views/ChoosePassword/index.js Outdated Show resolved Hide resolved
app/components/Views/ChoosePassword/index.js Show resolved Hide resolved
app/components/Views/ChoosePassword/index.js Show resolved Hide resolved
@sethkfman sethkfman changed the title iOS Biometric Deny Handler iOS FaceID Deny Handler Nov 11, 2021
@sethkfman sethkfman changed the title iOS FaceID Deny Handler [FIX] iOS FaceID Deny Handler Nov 16, 2021
@Cal-L Cal-L removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 16, 2021
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sethkfman sethkfman merged commit e08af6a into develop Nov 16, 2021
@sethkfman sethkfman deleted the fix/ios_biometric_deny branch November 16, 2021 22:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Unable to create wallet when you deny facial biometrics
3 participants