Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Enable sentry performance #3397

Merged
merged 4 commits into from
Nov 16, 2021
Merged

[IMPROVEMENT] Enable sentry performance #3397

merged 4 commits into from
Nov 16, 2021

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Nov 10, 2021

Description

#3285

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@Cal-L Cal-L requested a review from a team as a code owner November 10, 2021 18:19
@Cal-L Cal-L added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 10, 2021
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added needs-qa Any New Features that needs a full manual QA prior to being added to a release. No QA Needed Apply this label when your PR does not need any QA effort. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 10, 2021
@sethkfman sethkfman changed the title Enable sentry performance [IMPROVEMENT] Enable sentry performance Nov 16, 2021
sethkfman
sethkfman approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 16, 2021
cortisiko
cortisiko approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can no longer reproduce the timeout issue we faced while running e2e on this PR. 🌮

@sethkfman sethkfman merged commit 41daa7f into develop Nov 16, 2021
@sethkfman sethkfman deleted the feature/3285-add-sentry-performance branch November 16, 2021 20:57
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
next release No QA Needed Apply this label when your PR does not need any QA effort.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cal-L @sethkfman @cortisiko