Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UPGRADE] Android SDK and dependencies to support SDK 30 #3412

Merged
merged 8 commits into from
Nov 16, 2021
Merged

[UPGRADE] Android SDK and dependencies to support SDK 30 #3412

merged 8 commits into from
Nov 16, 2021

Conversation

sethkfman
Copy link
Contributor

Description

Bump Android SDK version to compile and target 30. Also, updated dependencies required for this bump.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@sethkfman sethkfman requested a review from a team as a code owner November 12, 2021 16:41
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

rickycodes
rickycodes requested changes Nov 12, 2021
View reviewed changes
Copy link
Member

@rickycodes rickycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me and no longer crashes woot

just a few small things. awesome stuff.

android/app/build.gradle Outdated Show resolved Hide resolved
app/components/Views/Entry/index.js Outdated Show resolved Hide resolved
@sethkfman sethkfman closed this Nov 12, 2021
@sethkfman sethkfman reopened this Nov 12, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2021
@sethkfman sethkfman marked this pull request as draft November 12, 2021 19:54
@rickycodes rickycodes self-requested a review November 16, 2021 17:51
rickycodes
rickycodes approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@rickycodes rickycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickycodes rickycodes marked this pull request as ready for review November 16, 2021 17:57
cortisiko
cortisiko approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🌮

@sethkfman sethkfman merged commit dff428b into develop Nov 16, 2021
@sethkfman sethkfman deleted the upgrade/android-sdk-30-bump branch November 16, 2021 22:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rickycodes rickycodes rickycodes approved these changes

@cortisiko cortisiko cortisiko approved these changes

Assignees
No one assigned
Labels
next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sethkfman @rickycodes @cortisiko