Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better initial state for swaps loading tokens #3430

Merged
merged 3 commits into from
Nov 22, 2021
Merged

Add better initial state for swaps loading tokens #3430

merged 3 commits into from
Nov 22, 2021

Conversation

wachunei
Copy link
Member

Description

This PRs adds a loading state to swaps while tokens are being fetched.

Screen Shot 2021-11-17 at 13 25 32

@wachunei wachunei marked this pull request as ready for review November 17, 2021 16:42
@wachunei wachunei requested a review from a team as a code owner November 17, 2021 16:42
rickycodes
rickycodes approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@rickycodes rickycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Nov 17, 2021
@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 22, 2021
cortisiko
cortisiko approved these changes Nov 22, 2021
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮

@wachunei wachunei merged commit 69654c9 into develop Nov 22, 2021
@wachunei wachunei deleted the fix/swaps-better-initial-state branch November 22, 2021 20:56
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rickycodes rickycodes rickycodes approved these changes

@cortisiko cortisiko cortisiko approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wachunei @rickycodes @cortisiko