-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPROVEMENT] Updated copy for drawer items to match extension #3480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
sethkfman
added
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
Dec 7, 2021
sethkfman
changed the title
updated copy for drawer items to match extension
[IMPROVEMENT] Updated copy for drawer items to match extension
Dec 7, 2021
gantunesr
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gantunesr
removed
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
Dec 8, 2021
sethkfman
added
the
needs-qa
Any New Features that needs a full manual QA prior to being added to a release.
label
Dec 9, 2021
gantunesr
added
the
Code Impact - Low
Minor code change that can safely applied to the codebase
label
Jan 21, 2022
chrisleewilcox
added
QA in Progress
QA has started on the feature.
and removed
needs-qa
Any New Features that needs a full manual QA prior to being added to a release.
labels
Jan 31, 2022
andrepimenta
added
Spot Check on the Release Build
If a ticket doesn't require feature QA, but does require some form of manual spot checking
and removed
QA in Progress
QA has started on the feature.
labels
Feb 4, 2022
Will need to spot check supported languages after merge to main. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Code Impact - Low
Minor code change that can safely applied to the codebase
Spot Check on the Release Build
If a ticket doesn't require feature QA, but does require some form of manual spot checking
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drawer copy change to have parity with the extension.
Checklist
Issue
Resolves #3134