Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Updated copy for drawer items to match extension #3480

Merged
merged 10 commits into from
Feb 4, 2022

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Dec 6, 2021

Description

Drawer copy change to have parity with the extension.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #3134

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman self-assigned this Dec 7, 2021
@sethkfman sethkfman added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 7, 2021
@sethkfman sethkfman marked this pull request as ready for review December 7, 2021 00:53
@sethkfman sethkfman requested a review from a team as a code owner December 7, 2021 00:53
@sethkfman sethkfman changed the title updated copy for drawer items to match extension [IMPROVEMENT] Updated copy for drawer items to match extension Dec 7, 2021
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 8, 2021
@sethkfman sethkfman added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Dec 9, 2021
@gantunesr gantunesr added the Code Impact - Low Minor code change that can safely applied to the codebase label Jan 21, 2022
@sethkfman sethkfman changed the base branch from develop to main January 26, 2022 18:40
@chrisleewilcox chrisleewilcox added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jan 31, 2022
@andrepimenta andrepimenta added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed QA in Progress QA has started on the feature. labels Feb 4, 2022
@andrepimenta andrepimenta merged commit 4d26f10 into main Feb 4, 2022
@andrepimenta andrepimenta deleted the fix/drawer-copy-change branch February 4, 2022 19:20
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2022
@chrisleewilcox
Copy link
Contributor

Will need to spot check supported languages after merge to main.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Code Impact - Low Minor code change that can safely applied to the codebase Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update 2 copy changes to be in parity with Extension
4 participants