Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confirm button disabled #3481

Merged
merged 3 commits into from
Jan 20, 2022
Merged

Fix confirm button disabled #3481

merged 3 commits into from
Jan 20, 2022

Conversation

andrepimenta
Copy link
Member

@andrepimenta andrepimenta commented Dec 7, 2021

Description

Fix confirm button disabled. How to test:
go to https://bridge.arbitrum.io/ and send ETH from Arbitrum to Mainnet (L2 -> L1). The "Confirm" button is sometimes disabled. You can test with Arbirum Testnet
#3318 (comment)

@cortisiko Please also test other transactions just to make sure the validation is not broken by this.

Checklist

  • There is a related GitHub issue

Issue

Resolves #3318

@andrepimenta andrepimenta requested a review from a team as a code owner December 7, 2021 17:17
@andrepimenta andrepimenta added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Dec 7, 2021
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickycodes rickycodes removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 8, 2021
@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jan 4, 2022
@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Jan 18, 2022
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🌮

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L merged commit 2a0da65 into develop Jan 20, 2022
@Cal-L Cal-L deleted the fix/confirm-button-disabled branch January 20, 2022 18:14
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to confirm Metamask Mobile Transaction
5 participants