-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Fixes renderFromGwei related crashes #3538
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
app/components/UI/Notification/TransactionNotification/index.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for working through the suggestions :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🚀 🚀
@andreahaku can you provide steps to reproduce the bug for QA? Please |
This can be replicated by doing and ETH transaction from one account to another (same wallet or different wallet) and by tapping on any of the popup notification messages confirming the transaction on both the sending and/or receiving wallets/accounts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮 🌮 🌮 🌮
Description
Fixes some crashes related to transaction notification info display and others related to calculating/displaying gas fees. The main issue was that calculated gwei where not always integers/string format but could be undefined/decimal crashing the numberToBN method.
Checklist
Issue
Resolves #3537