Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Removed copy "sync with extension" in the settings view #3562

Merged
merged 3 commits into from
Feb 4, 2022
Merged

[IMPROVEMENT] Removed copy "sync with extension" in the settings view #3562

merged 3 commits into from
Feb 4, 2022

Conversation

sethkfman
Copy link
Contributor

Description

Removed sync with extension copy in settings view.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@sethkfman sethkfman added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Code Impact - Low Minor code change that can safely applied to the codebase labels Jan 11, 2022
@sethkfman sethkfman requested a review from a team as a code owner January 11, 2022 16:30
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

andreahaku
andreahaku approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guessed you've used Google translator to find the right pieces to remove :D

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 11, 2022
@sethkfman sethkfman changed the base branch from develop to main January 26, 2022 18:35
@andrepimenta andrepimenta added the Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking label Feb 4, 2022
@andrepimenta andrepimenta merged commit 52b17ef into main Feb 4, 2022
@andrepimenta andrepimenta deleted the improvement/remove-sync-copy-settings branch February 4, 2022 20:50
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreahaku andreahaku andreahaku approved these changes

Assignees
No one assigned
Labels
Code Impact - Low Minor code change that can safely applied to the codebase Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sethkfman @andreahaku @andrepimenta @gantunesr