code optimization, extract common code hooks usePrevious #3573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I have read the CLA Document and I hereby sign the CLA |
gantunesr
requested changes
Jan 14, 2022
gantunesr
added
needs-dev-review
|
ok |
gantunesr
reviewed
Jan 14, 2022
gantunesr
requested changes
Jan 14, 2022
|
what do i need to do next? |
refactor the hook code to TypeScript fix lint delete usePrevious.js, use ts
rickycodes
force-pushed
the
improvement/hooks-usePrevious
branch
from
dc6aa42
to
b384585
Compare
|
@nuoyz I've taken the liberty of squashing your commits (and properly attributing them). you're PR should be good to merge now as the CLA requirement is now satisfied. :) |
gantunesr
removed
the
needs-dev-review
gantunesr
approved these changes
Feb 7, 2022
gantunesr
removed
the
Code Impact - Low
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
code optimization: usePrevious code implementations exist in multiple files; Easy maintenance, common code implementation
Checklist
Issue
Resolves #???