Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix modal view when adding wallet address to address book #3618

Merged
merged 7 commits into from
Feb 16, 2022
Merged

fix modal view when adding wallet address to address book #3618

merged 7 commits into from
Feb 16, 2022

Conversation

blackdevelopa
Copy link
Contributor

@blackdevelopa blackdevelopa commented Jan 21, 2022 •
edited
Loading

Description
This PR moves up the modal when adding a wallet address to the address book

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #3617

@blackdevelopa blackdevelopa requested a review from a team as a code owner January 21, 2022 15:39
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa self-assigned this Jan 21, 2022
@blackdevelopa blackdevelopa added type-bug Something isn't working Code Impact - Low Minor code change that can safely applied to the codebase needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jan 21, 2022
@blackdevelopa blackdevelopa changed the base branch from develop to main February 4, 2022 13:50
@blackdevelopa blackdevelopa force-pushed the fix/3617-fix-modal-view branch from 0731ac7 to 549e882 Compare February 4, 2022 14:30
@andrepimenta andrepimenta added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Feb 4, 2022
andreahaku
andreahaku approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 11, 2022
@cortisiko cortisiko added QA in Progress QA has started on the feature. QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. QA in Progress QA has started on the feature. labels Feb 15, 2022
cortisiko
cortisiko approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮

@cortisiko cortisiko merged commit fe69b06 into main Feb 16, 2022
@cortisiko cortisiko deleted the fix/3617-fix-modal-view branch February 16, 2022 19:51
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@andreahaku andreahaku andreahaku approved these changes

Assignees

@blackdevelopa blackdevelopa

Labels
Code Impact - Low Minor code change that can safely applied to the codebase QA Passed A successful QA run through has been done type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Half of the buttons are hidden under the keyboard
5 participants
@blackdevelopa @andreahaku @cortisiko @andrepimenta @gantunesr