Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slider button rerendering #3623

Merged
merged 2 commits into from
Jan 25, 2022
Merged

Fix slider button rerendering #3623

merged 2 commits into from
Jan 25, 2022

Conversation

wachunei
Copy link
Member

Description
This PR fixes a rerendering issue that caused a sloppy animation when dragging the slider button to confirm swap

@wachunei wachunei marked this pull request as ready for review January 21, 2022 23:38
@wachunei wachunei requested a review from a team as a code owner January 21, 2022 23:38
rickycodes
rickycodes approved these changes Jan 22, 2022
View reviewed changes
Copy link
Member

@rickycodes rickycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm

cortisiko
cortisiko approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮

@wachunei wachunei merged commit bcf3212 into develop Jan 25, 2022
@wachunei wachunei deleted the fix/swipe-slider-button branch January 25, 2022 17:40
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rickycodes rickycodes rickycodes approved these changes

@cortisiko cortisiko cortisiko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wachunei @rickycodes @cortisiko