Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade controllers to 25.1.0 #3638

Merged
merged 11 commits into from
Feb 28, 2022
Merged

Upgrade controllers to 25.1.0 #3638

merged 11 commits into from
Feb 28, 2022

Conversation

gantunesr
Copy link
Member

Description

Controllers dependence upgrade 22.0.0 -> 25.1.0.

Breaking changes for mobile

  1. New standardize method names for the AssetsContractController.

Breaking changes from v23.0.0 and v24.0.0 are not applicable to Mobile.

@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Code Impact - Medium Average task code change that can relatively safely being applied to the codebase labels Jan 25, 2022
@gantunesr gantunesr requested review from adonesky1 and a team January 25, 2022 12:31
@andrepimenta andrepimenta added the Priority - High Task with high priority label Feb 4, 2022
Cal-L
Cal-L approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr mentioned this pull request Feb 9, 2022
Closed
5 tasks
@gantunesr gantunesr added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Feb 13, 2022
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gantunesr gantunesr changed the base branch from develop to main February 13, 2022 23:26
@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking labels Feb 16, 2022
@chrisleewilcox chrisleewilcox added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Feb 16, 2022
chrisleewilcox
chrisleewilcox requested changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an issue found...

-after swapping on polygon (matic to uniswap) I get an error "TypeError: null is not an object (evaluating reciept.blockHash')
https://www.screencast.com/t/aMj56jrIX
If i were to do another swap i get:
see here: http://recordit.co/cR2QTYpN1S
image

@chrisleewilcox chrisleewilcox added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed QA in Progress QA has started on the feature. labels Feb 22, 2022
chrisleewilcox
chrisleewilcox approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errors seen while testing are not related to this PR.

@chrisleewilcox chrisleewilcox added the QA Passed A successful QA run through has been done label Feb 25, 2022
@gantunesr gantunesr changed the title Upgrade controllers 22.0.0 -> 25.1.0 Upgrade controllers to 25.1.0 Feb 25, 2022
@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 26, 2022
@gantunesr gantunesr merged commit 2595eaf into main Feb 28, 2022
@gantunesr gantunesr deleted the depend/controllers-25.1.0 branch February 28, 2022 13:24
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

@Cal-L Cal-L Cal-L approved these changes

@adonesky1 adonesky1 Awaiting requested review from adonesky1

Assignees
No one assigned
Labels
Code Impact - Medium Average task code change that can relatively safely being applied to the codebase Priority - High Task with high priority QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gantunesr @chrisleewilcox @Cal-L @andrepimenta