Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Update texts to use lock/unlock terminology #3724

Merged
merged 10 commits into from
Feb 16, 2022

Conversation

gantunesr
Copy link
Member

Description

Papercuts: Update login/logout texts to use lock/unlock terminology. In a future refactor, variables and components should also use the keywords lock and unlock instead of login and logout for consistency.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr requested a review from a team as a code owner February 9, 2022 16:10
@gantunesr gantunesr added Code Impact - Low Minor code change that can safely applied to the codebase needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking labels Feb 9, 2022
Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 14, 2022
@gantunesr gantunesr merged commit bda065c into main Feb 16, 2022
@gantunesr gantunesr deleted the enhan/papercuts/update-login-texts branch February 16, 2022 19:36
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Code Impact - Low Minor code change that can safely applied to the codebase Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants