Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Release - Potential error message from missing transactions details #3741

Merged
merged 3 commits into from
Feb 14, 2022
Merged

[FIX] Release - Potential error message from missing transactions details #3741

merged 3 commits into from
Feb 14, 2022

Conversation

andreahaku
Copy link
Member

Description
Fixes potential error from missing transaction details:

image

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

No related issues.

@andreahaku andreahaku requested a review from a team as a code owner February 14, 2022 11:10
@andreahaku andreahaku added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Feb 14, 2022
@andreahaku andreahaku changed the base branch from main to release/v4.1.0-RC1 February 14, 2022 11:11
gantunesr
gantunesr approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gantunesr gantunesr requested a review from Fatxx February 14, 2022 16:03
@andreahaku andreahaku merged commit d89f2d9 into release/v4.1.0-RC1 Feb 14, 2022
@andreahaku andreahaku deleted the fix/release/missing-transaction-details branch February 14, 2022 16:26
@andreahaku andreahaku removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Feb 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Fatxx Fatxx Fatxx approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreahaku @Fatxx @gantunesr