Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Error message not displayed #3791

Merged
merged 2 commits into from
Feb 24, 2022
Merged

[FIX] Error message not displayed #3791

merged 2 commits into from
Feb 24, 2022

Conversation

gantunesr
Copy link
Member

Description

The error message is not displaying while setting a custom spend limit

drawing

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr requested a review from a team as a code owner February 21, 2022 19:16
@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking labels Feb 22, 2022
andreahaku
andreahaku approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr merged commit fe5a920 into main Feb 24, 2022
@gantunesr gantunesr deleted the fix/error-message-style branch February 24, 2022 20:07
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreahaku andreahaku andreahaku approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gantunesr @andreahaku