Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fantom FTM and Celo CELO — Add token after fiat on ramp order. #3797

Merged
merged 9 commits into from
Feb 24, 2022
Merged

Add Fantom FTM and Celo CELO — Add token after fiat on ramp order. #3797

merged 9 commits into from
Feb 24, 2022

Conversation

wachunei
Copy link
Member

⚠️ This PR is branched off #3768

This PR adds the asset to the token list after completing a Transak order

@wachunei wachunei added the team-ramp issues related to Ramp features label Feb 22, 2022
@wachunei wachunei marked this pull request as ready for review February 22, 2022 19:33
@wachunei wachunei requested a review from a team as a code owner February 22, 2022 19:33
@wachunei wachunei added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 22, 2022
@gantunesr
Copy link
Member

⚠️ This PR is branched off #3768

This PR adds the asset to the token list after completing a Transak order

Is this PR blocked by #3768?

@wachunei
Copy link
Member Author

Is not blocked but if we merge this we merge #3768 because it includes its changes.

@wachunei wachunei mentioned this pull request Feb 24, 2022
Closed
@wachunei wachunei changed the title Add token after fiat on ramp order Add Fantom FTM and Celo CELO — Add token after fiat on ramp order. Feb 24, 2022
@wachunei wachunei added the Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking label Feb 24, 2022
@gantunesr gantunesr merged commit 1aa2f1d into main Feb 24, 2022
@gantunesr gantunesr deleted the feature/add-token-after-onramp branch February 24, 2022 19:54
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreahaku andreahaku andreahaku left review comments

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wachunei @gantunesr @andreahaku