Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gas fee on education wizard and related JSON parse error #3803

Merged
merged 11 commits into from
Mar 1, 2022
Merged

Fix gas fee on education wizard and related JSON parse error #3803

merged 11 commits into from
Mar 1, 2022

Conversation

Fatxx
Copy link
Contributor

@Fatxx Fatxx commented Feb 23, 2022

Description

Replace old Codefi API endpoint with GasController method to fetch gas fee estimates.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #3759 and #3626

@Fatxx Fatxx requested a review from a team as a code owner February 23, 2022 15:31
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Fatxx Fatxx added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Feb 23, 2022
@Fatxx Fatxx linked an issue Feb 24, 2022 that may be closed by this pull request
Gas fee number does not load #3626
Closed
@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Feb 24, 2022
cortisiko
cortisiko approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮

andrepimenta
andrepimenta approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@andrepimenta andrepimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fatxx Fatxx merged commit 7a1b2fc into main Mar 1, 2022
@Fatxx Fatxx deleted the fix/gas-fee-on-education-wizard branch March 1, 2022 17:07
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wachunei wachunei wachunei left review comments

@cortisiko cortisiko cortisiko approved these changes

@andrepimenta andrepimenta andrepimenta approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON Parse error: Unrecognized token '<' Gas fee number does not load
4 participants
@Fatxx @wachunei @andrepimenta @cortisiko