Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix go to ens domain when coming from qr code #3888

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Fix go to ens domain when coming from qr code #3888

merged 2 commits into from
Mar 15, 2022

Conversation

andrepimenta
Copy link
Member

Description

Fix go to ens domain when coming from QR Code

How to test:
Reach out to @andrepimenta for an example link and QR Code

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@andrepimenta andrepimenta requested a review from a team as a code owner March 13, 2022 18:31
@andrepimenta andrepimenta added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 13, 2022
sethkfman
sethkfman approved these changes Mar 13, 2022
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrepimenta andrepimenta added Priority - High Task with high priority next release and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 14, 2022
@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Mar 15, 2022
cortisiko
cortisiko approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Mar 15, 2022
@andrepimenta andrepimenta merged commit de42413 into main Mar 15, 2022
@andrepimenta andrepimenta deleted the fix/go-to-ens-domain-from-qr-code branch March 15, 2022 17:57
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
next release Priority - High Task with high priority QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrepimenta @sethkfman @cortisiko