Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network Specific Asset Education - Updated #3910

Merged
merged 26 commits into from
Mar 28, 2022
Merged

Network Specific Asset Education - Updated #3910

merged 26 commits into from
Mar 28, 2022

Conversation

blackdevelopa
Copy link
Contributor

Description

This PR updates a user when they toggle to a different network and have no token/funds present.
https://app.zenhub.com/workspaces/metamask-mobile-5f984938ddc0e4001d4b79cb/issues/metamask/mobile-planning/149

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #3648

@blackdevelopa blackdevelopa requested a review from a team as a code owner March 17, 2022 18:25
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa self-assigned this Mar 17, 2022
@blackdevelopa blackdevelopa mentioned this pull request Mar 18, 2022
Closed
3 tasks
@blackdevelopa blackdevelopa added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 18, 2022
@blackdevelopa blackdevelopa force-pushed the feature/149-network-asset-education-update branch from 76f1240 to fffac56 Compare March 24, 2022 11:19
@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Mar 25, 2022
cortisiko
cortisiko approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮

@blackdevelopa blackdevelopa merged commit fa63312 into main Mar 28, 2022
@blackdevelopa blackdevelopa deleted the feature/149-network-asset-education-update branch March 28, 2022 11:42
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@owencraston owencraston owencraston approved these changes

Assignees

@blackdevelopa blackdevelopa

Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blackdevelopa @cortisiko @owencraston @sethkfman