Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix error boundary SRP #3946

Merged
merged 2 commits into from
Mar 23, 2022
Merged

[Fix] Fix error boundary SRP #3946

merged 2 commits into from
Mar 23, 2022

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Mar 23, 2022

Description

#3944

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@Cal-L Cal-L added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 23, 2022
@Cal-L Cal-L requested a review from a team as a code owner March 23, 2022 19:53
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L changed the base branch from main to release/4.3.1 March 23, 2022 19:53
sethkfman
sethkfman approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L merged commit a741c55 into release/4.3.1 Mar 23, 2022
@Cal-L Cal-L deleted the fix/3944-error-boundary-srp branch March 23, 2022 20:15
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2022
@cortisiko cortisiko removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Apr 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cal-L @sethkfman @cortisiko