-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch network specific asset modal (Token detection) #3980
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
app/components/UI/NetworkInfo/InfoDescription/infoDescription.tsx
Outdated
Show resolved
Hide resolved
User testing results
|
Here we can see when token detection is on, the asset education modal messaging is different, indicating that tokens should be auto imported.
|
5660a2a
to
1551b0a
Compare
app/components/UI/NetworkInfo/InfoDescription/infoDescription.tsx
Outdated
Show resolved
Hide resolved
app/components/UI/NetworkInfo/InfoDescription/infoDescription.tsx
Outdated
Show resolved
Hide resolved
app/components/UI/NetworkInfo/InfoDescription/infoDescription.tsx
Outdated
Show resolved
Hide resolved
Getting the following error when running
|
afcc75f
to
f866f49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge. Translation can be handle in a different issue.
Description
Patched network specific assets education modal to include token detection (mainnet)
Checklist
Issue
Resolves #???