Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Remove hardcoded fill on SVG #4033

Merged
merged 2 commits into from
Apr 5, 2022
Merged

[FIX] Remove hardcoded fill on SVG #4033

merged 2 commits into from
Apr 5, 2022

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Apr 4, 2022

Description

#4032

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Progresses #???

@Cal-L Cal-L requested a review from a team as a code owner April 4, 2022 18:31
@Cal-L Cal-L added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

gantunesr
gantunesr approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L merged commit 03c523e into main Apr 5, 2022
@Cal-L Cal-L deleted the bug/4032-remove-hardcoded-fill-on-svg branch April 5, 2022 00:01
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2022
@mobularay mobularay added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Apr 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr approved these changes

Assignees

@Cal-L Cal-L

Labels
Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Cal-L @gantunesr @cortisiko @mobularay