Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Avoid canceling transactions after submission #4060

Merged
merged 10 commits into from
Jun 9, 2022

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Apr 8, 2022

Description
When we put the app in the background we were trying to cancel the transaction. The transaction still succeeded because the transaction status it's not cancelable but shows one notification that says "Oops Something went wrong".

Proposed solution
The proposed solution is only to cancel the transaction if the status it's not, submitted, cancellable, approved, failed and rejected when the app goes to the background.

Code Impact
The code impact is low, since we just change the code when the app state (foreground, background), changes.

Screenshots/Videos
Bug:
https://recordit.co/Pqa7Uq34hv

Solution:
https://recordit.co/EkE0jdyCMj

Test Cases
Case1:

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue
Progresses ##3927

@tommasini tommasini requested a review from a team as a code owner April 8, 2022 18:03
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. Mobile QA board labels Apr 13, 2022
app/components/Views/Approval/index.js Outdated Show resolved Hide resolved
app/components/Views/Approval/index.js Outdated Show resolved Hide resolved
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini
Copy link
Contributor Author

Test case 1:

@gantunesr gantunesr changed the title when tx is submitted we do not cancel anymore [FIX] Avoid canceling transactions after submission Apr 21, 2022
@Jens05
Copy link

Jens05 commented May 8, 2022

Any progress on this? If this issue is resolved i can continue with my Dapp :)

@Fatxx Fatxx changed the title [FIX] Avoid canceling transactions after submission [5.2][FIX] Avoid canceling transactions after submission May 10, 2022
@chrisleewilcox chrisleewilcox added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels May 14, 2022
@tommasini tommasini changed the title [5.2][FIX] Avoid canceling transactions after submission [FIX] Avoid canceling transactions after submission May 17, 2022
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ticket is QA passed. Scenarios I tested:

Send transaction
Swap transaction
dapps transactions.

I no longer see the ooops something went wrong alert message when the app was in the background. I also did not see that alert message when I killed and relaunched the app. Finally with push notifications turned on I did not receive a ooops something went wrong notification. Good work @tommasini 🌮 🌮

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Jun 8, 2022
@Fatxx Fatxx merged commit 8e51de3 into main Jun 9, 2022
@Fatxx Fatxx deleted the fix/3927-error-tx-toast-unexpected branch June 9, 2022 08:39
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2022
@tommasini tommasini added the release-5.3.0 Issue or pull request that will be included in release 5.3.0 label Jun 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-5.3.0 Issue or pull request that will be included in release 5.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants