Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Add ticker to SelectQRAccounts #4113

Merged
merged 3 commits into from
Apr 18, 2022
Merged

[FIX] Add ticker to SelectQRAccounts #4113

merged 3 commits into from
Apr 18, 2022

Conversation

gantunesr
Copy link
Member

Description

The component SelectQRAccounts has hardcoded the ticker ETH, this PR updates the component to use the ticker from the current network.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Progresses #4095

@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking labels Apr 16, 2022
@gantunesr gantunesr requested a review from a team as a code owner April 16, 2022 20:16
Fatxx
Fatxx approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@Fatxx Fatxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr merged commit fde94d3 into main Apr 18, 2022
@gantunesr gantunesr deleted the fix/account-select-ticker branch April 18, 2022 18:14
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Fatxx Fatxx Fatxx approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gantunesr @Fatxx