Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e coverage for invalid browser url & changing password #4129

Merged
merged 14 commits into from
Apr 27, 2022
Merged

Add e2e coverage for invalid browser url & changing password #4129

merged 14 commits into from
Apr 27, 2022

Conversation

cortisiko
Copy link
Member

Description

Write a short description of the changes included in this pull request.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Progresses #???

@cortisiko cortisiko requested a review from a team as a code owner April 19, 2022 20:28
@cortisiko cortisiko added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Apr 19, 2022
gantunesr
gantunesr approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some minor comments

e2e/specs/delete-wallet.spec.js Outdated Show resolved Hide resolved
app/constants/test-ids.js Outdated Show resolved Hide resolved
e2e/pages/Drawer/Browser.js Outdated Show resolved Hide resolved
e2e/pages/Drawer/Browser.js Show resolved Hide resolved
cortisiko and others added 3 commits April 19, 2022 17:43
@cortisiko
Update e2e/specs/delete-wallet.spec.js
3dec8c5 
Co-authored-by: Gustavo Antunes <gantunes@uc.cl>
@cortisiko
Update e2e/pages/Drawer/Browser.js
1f59211 
Co-authored-by: Gustavo Antunes <gantunes@uc.cl>
@cortisiko
Update e2e/pages/Drawer/Browser.js
8c5d59c 
Co-authored-by: Gustavo Antunes <gantunes@uc.cl>
@cortisiko cortisiko removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 19, 2022
chrisleewilcox
chrisleewilcox approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cortisiko cortisiko merged commit 38b1ca5 into main Apr 27, 2022
@cortisiko cortisiko deleted the detox/add-password-reset branch April 27, 2022 21:34
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr approved these changes

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cortisiko @chrisleewilcox @gantunesr